Load trace plugins via PluginManager and allow to set requeued plugins for trace session #8707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed plugins for trace session
|
The discussion: https://groups.google.com/u/1/g/firebird-devel/c/P93Ovd858wE |
src/jrd/trace/TraceManager.cpp
Outdated
|
|
||
| for (FactoryInfo* info = factories->begin(); info != factories->end(); ++info) | ||
| GetPlugins<ITraceFactory> traceItr(IPluginManager::TYPE_TRACE, session.getPluginsString()); | ||
| for (; traceItr.hasData(); traceItr.next()) |
There was a problem hiding this comment.
This plain-C style syntax (for-loop iterator declared before the loop) makes sense only when iterator is needed after the end of loop. Why not:
for (GetPlugins<ITraceFactory> traceItr(IPluginManager::TYPE_TRACE, session.getPluginsString());
traceItr.hasData(); traceItr.next())
There was a problem hiding this comment.
The line turned out to be too long. I didn't think about splitting the for operators
hvlad
requested changes
Aug 19, 2025
|
I added plugins printing to tracecmgr -LIST. Please review the changes |
hvlad
reviewed
Aug 20, 2025
hvlad
reviewed
Aug 20, 2025
hvlad
reviewed
Aug 20, 2025
hvlad
approved these changes
Aug 20, 2025
hvlad
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.